Shireesh Anjal has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
......................................................................
Patch Set 20: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 102: List<Pair<VDS, VDSReturnValue>> pairResults =
ThreadPoolUtil.invokeAll(taskList);
Line 103: for (Pair<VDS, VDSReturnValue> pairResult : pairResults) {
Line 104:
Line 105: VDSReturnValue retValue = pairResult.getSecond();
Line 106: if (retValue.getSucceeded()) {
Since the two lines here are getting repeated in the else part also, how about
something like this:
if (retValue.getSucceeded() ||
VdcBllErrors.GlusterHookAlreadyEnabled.equals(retValue.getVdsError().getCode()))
{
atLeastOneSuccess = true;
// update status in database
addOrUpdateServerHook(serverHooks, pairResult);
} else {
errors.add(retValue.getVdsError().getMessage());
}
Line 107: atLeastOneSuccess = true;
Line 108: // update status in database
Line 109: addOrUpdateServerHook(serverHooks, pairResult);
Line 110: } else {
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java
Line 187: cmd = spy(new EnableGlusterHookCommand(new
GlusterHookParameters(CLUSTER_ID, null)));
Line 188: setupMocks();
Line 189: assertFalse(cmd.canDoAction());
Line 190:
assertTrue(cmd.getReturnValue().getCanDoActionMessages().contains(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_HOOK_ID_IS_REQUIRED.toString()));
Line 191: }
Do we need to add one more test for the new check added for "hook with given id
doesn't exist" ?
Line 192:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
Line 21: public static final String OPTION_VALUE = "value";
Line 22: public static final String OPTION_OLD_VALUE = "oldvalue";
Line 23: public static final String OPTION_NEW_VALUE = "newvalue";
Line 24:
Line 25: public static final String HOOK_NAME = "glusterHookName";
the value needs to be all lower case (glusterhookname)
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 591: GLUSTER_SERVER_REMOVED_FROM_CLI=Detected server ${VdsName} removed
from Cluster ${VdsGroupName}, and removed it from engine DB.
Line 592: GLUSTER_VOLUME_STARTED_FROM_CLI=Detected that Volume
${glusterVolumeName} of Cluster ${VdsGroupName} was started, and updated engine
DB with it's new status.
Line 593: GLUSTER_VOLUME_STOPPED_FROM_CLI=Detected that Volume
${glusterVolumeName} of Cluster ${VdsGroupName} was stopped, and updated engine
DB with it's new status.
Line 594: GLUSTER_HOOK_ENABLE=Gluster Hook ${GlusterHookName} enabled.
Line 595: GLUSTER_HOOK_ENABLE_FAILED=Failed to enable Gluster Hook
${GlusterHookName}.
Maybe we should also print the cluster name (${VdsGroupName}) in these two
messages.
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
