Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
Line 76: runVdsCommand(VDSCommandType.ActivateVds, new
ActivateVdsVDSCommandParameters(getVdsId()));
Line 77: setSucceeded(returnValue.getSucceeded());
Line 78:
Line 79: if (getSucceeded()) {
Line 80: if
(FeatureSupported.setupNetworks(vds.getVdsGroupCompatibilityVersion())) {
I am not expert in engine... but won't it better to check this once here and
set command context so that InstallVdsCommand extract it and set property of
VdsDeploy?
This why only one component modifies the behavior of the chain.
Line 81: createManagementNetworkIfRequired((VDS)
returnValue.getReturnValue());
Line 82: }
Line 83:
Line 84: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
