Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 411: );
Line 412: return null;
Line 413: }},
Line 414: new Callable<Object>() { public Object call() throws
Exception {
Line 415: if
(FeatureSupported.setupNetworks(_vds.getVdsGroupCompatibilityVersion())) {
Yes, this will be better, but I wanted to avoid duplicate the logic.
How come the add host and the install host are different flows? doesn't one
command calls another? it is quite strange...
Line 416: _parser.cliNoop();
Line 417: } else {
Line 418: _parser.cliEnvironmentSet(
Line 419: VdsmEnv.MANAGEMENT_BRIDGE_NAME,
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
