Michael Kublin has posted comments on this change.
Change subject: engine: fetch gluster host uuid during InitVdsOnUp
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 350:
Line 351: private boolean saveGlusterHostUuid() {
Line 352: VdsGlusterDao vdsGlusterDao =
DbFacade.getInstance().getVdsGlusterDao();
Line 353: VdsGluster vdsGluster =
vdsGlusterDao.getById(getVds().getId());
Line 354: if (vdsGluster == null) {
Please pay attention if runVdsCommand will fail, exception will be thrown, so
returnValue.getSucceeded() never will be false and the line 284 will not be
executed
Line 355: VDSReturnValue returnValue =
runVdsCommand(VDSCommandType.GetGlusterHostUUID,
Line 356: new
VdsIdVDSCommandParametersBase(getVds().getId()));
Line 357: if (returnValue.getSucceeded() &&
returnValue.getReturnValue() != null) {
Line 358: vdsGluster = new VdsGluster();
--
To view, visit http://gerrit.ovirt.org/14166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied8e8b006adc5722cd70ee19d75a4b6f783d5f44
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
