Omer Frenkel has posted comments on this change. Change subject: engine: fetch gluster host uuid during InitVdsOnUp ......................................................................
Patch Set 5: (1 inline comment) looks ok to me, minor comment inside .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java Line 14: KVM_NOT_RUNNING(6), Line 15: TIMEOUT_RECOVERING_FROM_CRASH(7), Line 16: VM_NETWORK_IS_BRIDGELESS(8), Line 17: GLUSTER_COMMAND_FAILED(9), Line 18: GLUSTER_HOST_UUID_NOT_FOUND(10), i think this should have a localization string in LocalizedEnums.java and LocalizedEnums.properties Line 19: ; Line 20: Line 21: private final int value; Line 22: -- To view, visit http://gerrit.ovirt.org/14166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied8e8b006adc5722cd70ee19d75a4b6f783d5f44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
