Kanagaraj M has posted comments on this change.
Change subject: engine: fetch gluster host uuid during InitVdsOnUp
......................................................................
Patch Set 3: (5 inline comments)
New patch set to follow.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 63: public class InitVdsOnUpCommand extends
StorageHandlingCommandBase<HostStoragePoolParametersBase> {
Line 64: private boolean _fenceSucceeded = true;
Line 65: private boolean _vdsProxyFound;
Line 66: private boolean _connectStorageSucceeded, _connectPoolSucceeded;
Line 67: private boolean _glusterHostUuidFound, _glusterPeerListSucceeded,
_glusterPeerProbeSucceeded;
Done
Line 68: private FenceStatusReturnValue _fenceStatusReturnValue;
Line 69:
Line 70: public InitVdsOnUpCommand(HostStoragePoolParametersBase
parameters) {
Line 71: super(parameters);
Line 79: if (vdsGroup.supportsVirtService()) {
Line 80: setSucceeded(initVirtResources());
Line 81: }
Line 82:
Line 83: if (vdsGroup.supportsGlusterService()) {
Done
Line 84: setSucceeded(initGlusterHost());
Line 85: }
Line 86: }
Line 87:
Line 236: public AuditLogType getAuditLogTypeValue() {
Line 237: AuditLogType type = AuditLogType.UNASSIGNED;
Line 238:
Line 239: if (getVdsGroup().supportsGlusterService()) {
Line 240: if (!_glusterHostUuidFound) {
Done
Line 241: type = AuditLogType.GLUSTER_HOST_UUID_NOT_FOUND;
Line 242: } else if (!_glusterPeerListSucceeded) {
Line 243: type = AuditLogType.GLUSTER_SERVERS_LIST_FAILED;
Line 244: } else if (!_glusterPeerProbeSucceeded) {
Line 323: }
Line 324:
Line 325: private boolean hostExists(List<GlusterServerInfo>
glusterServers, VDS server) {
Line 326: if
(GlusterFeatureSupported.glusterHostUuidSupported(getVdsGroup().getcompatibility_version()))
{
Line 327: VdsGluster vdsGluster =
DbFacade.getInstance().getVdsGlusterDao().getById(getVds().getId());
Done
Line 328: if (vdsGluster != null) {
Line 329: for (GlusterServerInfo glusterServer :
glusterServers) {
Line 330: if
(glusterServer.getUuid().equals(vdsGluster.getGlusterHostUuid())) {
Line 331: return true;
Line 338: if
(glusterServer.getHostnameOrIp().equals(server.getHostName())) {
Line 339: return true;
Line 340: }
Line 341: for (VdsNetworkInterface vdsNwInterface :
getVdsInterfaces(server.getId())) {
Line 342: if
(glusterServer.getHostnameOrIp().equals(vdsNwInterface.getAddress())) {
Done
Line 343: return true;
Line 344: }
Line 345: }
Line 346: }
--
To view, visit http://gerrit.ovirt.org/14166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied8e8b006adc5722cd70ee19d75a4b6f783d5f44
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
