Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: cleanup Frontend ......................................................................
Patch Set 1: (5 inline comments) .................................................... Commit Message Line 12: - Replaced calls to deprecated methods which returned null with Line 13: just null. Line 14: Line 15: Change-Id: I36b970b9b53ff568bef04c41859a1dcc958c98f8 Line 16: Bug-Url: https://bugzilla.redhat.com/?????? redundant .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java Line 489 Line 490 Line 491 Line 492 Line 493 Don't you think we should keep this signature and just implement it as 'RunAction(actionType, parameters, Frontend.NULLABLE_ASYNC_CALLBACK)' ? Line 577 Line 578 Line 579 Line 580 Line 581 I think it was deprecated by mistake. This signature is actually useful and we use when appropriate. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java Line 396: for (Object model : hostsModel.getHosts().getSelectedItems()) { Line 397: String host = (String) ((EntityModel) model).getEntity(); Line 398: parametersList.add(new RemoveGlusterServerParameters(getEntity().getId(), host, force)); Line 399: } Line 400: Frontend.RunMultipleAction(VdcActionType.RemoveGlusterServer, parametersList, null, null); see my previous comment in Frontend class Line 401: Cancel(); Line 402: } Line 403: Line 404: public void Cancel() .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java Line 358: if (selectedHost.getStatus() == VDSStatus.PendingApproval && retVals.get(i) != null Line 359: && retVals.get(i).getSucceeded()) Line 360: { Line 361: Frontend.RunAction(VdcActionType.ApproveVds, Line 362: new ApproveVdsParameters(selectedHost.getId()), see my previous comment in Frontend class Line 363: Frontend.NULLABLE_ASYNC_CALLBACK); Line 364: } Line 365: } Line 366: i++; -- To view, visit http://gerrit.ovirt.org/14410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36b970b9b53ff568bef04c41859a1dcc958c98f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
