Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: cleanup Frontend
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java
Line 68: for (Object item : getSelectedItems()) {
Line 69: GlusterHookEntity hook = (GlusterHookEntity) item;
Line 70: list.add(new GlusterHookParameters(getEntity().getId(),
hook.getId()));
Line 71: }
Line 72: Frontend.RunMultipleAction(VdcActionType.EnableGlusterHook,
list);
no need for this change now
Line 73: }
Line 74:
Line 75: private void disableHook() {
Line 76: if (getWindow() != null) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
Line 207: !getEntity().isInitialized() &&
AsyncDataProvider.IsWindowsOsType(getEntity().getVmOs());
Line 208: RunVmParams tempVar = new
RunVmParams(getEntity().getId());
Line 209:
tempVar.setRunAsStateless(getEntity().isStateless());
Line 210: tempVar.setReinitialize(reinitialize);
Line 211: Frontend.RunMultipleAction(VdcActionType.RunVm,
Since not related to the Frontend changes, I think it's better to just revert
this file (the formatting can be done later on in a consecutive patch).
Line 212: new ArrayList<VdcActionParametersBase>(
Line 213: Arrays.asList(new
VdcActionParametersBase[] { tempVar })));
Line 214:
Line 215: } else if
(StringHelper.stringsEqual(item.getCommandName(), CommandSuspend)) {
--
To view, visit http://gerrit.ovirt.org/14410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b970b9b53ff568bef04c41859a1dcc958c98f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
