Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: cleanup Frontend ......................................................................
Patch Set 5: Looks good to me, but someone else must approve Patch looks good to me. With Frontend.RegisterQuery/RegisterSearch removed, you can also consider removing SearchableListModel.asyncResult and any methods using this field (getAsyncResult/setAsyncResult/AsyncResultChanging). AFAIK RegisterQuery/RegisterSearch were meant to remotely register query/search on server and get notified later on when query/search completes, but this feature isn't currently supported/used. -- To view, visit http://gerrit.ovirt.org/14410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36b970b9b53ff568bef04c41859a1dcc958c98f8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
