Barak Azulay has posted comments on this change.

Change subject: Adding parameters to delay fence based on host's load
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 604:                 // delay time can be fracture number, casting it to 
int should be enough
Line 605:                 Config.<Integer> 
GetValue(ConfigValues.TimeoutToResetVdsInSeconds) +
Line 606:                 (Config.<Double> 
GetValue(ConfigValues.DelayResetForSpmInSeconds) * spmIndicator) +
Line 607:                 (Config.<Double> 
GetValue(ConfigValues.DelayResetPerVmInSeconds) * vmCount)));
Line 608:     }
Since the time out now is variable we need to log (INFO) the time out and it's 
factors (spm & #of VMS), but we need to do it only when fencing is actually 
called.
Line 609:     /**
Line 610:      * Handle network exception, return true if save vdsDynamic to DB 
is needed.
Line 611:      *
Line 612:      * @param ex


--
To view, visit http://gerrit.ovirt.org/14288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to