Maor Lipchuk has posted comments on this change.
Change subject: Adding parameters to delay fence based on host's load
......................................................................
Patch Set 6: (1 inline comment)
looks good, minor comment.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 594: throw new
RuntimeException(vdsBrokerCommand.getVDSReturnValue().getExceptionString());
Line 595: }
Line 596: }
Line 597:
Line 598: private double calcTimeoutToFence(int vmCount, VdsSpmStatus
spmStatus) {
TimeUnit.SECONDS.toMillis should return long, the return type should be long as
well.
Line 599: int spmIndicator = 0;
Line 600: if (spmStatus != VdsSpmStatus.None) {
Line 601: spmIndicator = 1;
Line 602: }
--
To view, visit http://gerrit.ovirt.org/14288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
