Omer Frenkel has posted comments on this change. Change subject: Adding parameters to delay fence based on host's load ......................................................................
Patch Set 5: (2 inline comments) please update the wiki with new logic http://www.ovirt.org/Automatic_Fencing .................................................... File backend/manager/dbscripts/upgrade/03_03_0110_delay_fence_parameters.sql Line 1: select fn_db_add_config_value('DelayResetForSpmInSeconds','20','general'); Line 2: select fn_db_add_config_value('DelayResetPerVmInSeconds','0.5','general'); should be in 000 config file .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java Line 596: } Line 597: Line 598: private double calcTimeoutToFence(int vmCount, VdsSpmStatus spmStatus) { Line 599: int spmIndicator = 0; Line 600: if (spmStatus == VdsSpmStatus.SPM) { maybe check spmStatus != None since contending might be considered as SPM as well? Line 601: spmIndicator = 1; Line 602: } Line 603: return TimeUnit.SECONDS.toMillis((int)( Line 604: // delay time can be fracture number, casting it to int should be enough -- To view, visit http://gerrit.ovirt.org/14288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
