Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: uicommon cleanup
......................................................................
Patch Set 1: Verified
(2 inline comments)
I have two questions in the review.
Verified as everything seemed to work fine after applying this patch. I found
no code that actually called the 'async' methods. Except for the one sync
method that I have a question about in the review.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
Line 93: @Override
Line 94: protected void syncSearch()
Line 95: {
Line 96: super.syncSearch();
Line 97: Task.Create(this, null).InvokeUIThread();
Not 100% sure I got the logic right here. Is this even needed?
Line 98: }
Line 99:
Line 100: public void UpdateOptionsAsync(String search)
Line 101: {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 773:
Line 774: setIsQueryFirstTime(false);
Line 775: }
Line 776:
Line 777: public void EnsureAsyncSearchStopped()
Might be a good idea to rename this to stopRefresh instead?
Line 778: {
Line 779: getTimer().stop();
Line 780: }
Line 781:
--
To view, visit http://gerrit.ovirt.org/14654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica13e40edf51b91cec88405ae275b08c70edef44
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
