Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: uicommon cleanup ......................................................................
Patch Set 2: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java Line 55 Line 56 Line 57 Line 58 Line 59 Most likely yes, but removing this and the associated getter and setter caused a bunch of other files to need changes as well. I want to limit the number of changes and that is why I didn't remove this with the associated getter/setter. It would definitely be on the list for another cleanup though. -- To view, visit http://gerrit.ovirt.org/14654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica13e40edf51b91cec88405ae275b08c70edef44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
