Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: uicommon cleanup
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
Line 93: @Override
Line 94: protected void syncSearch()
Line 95: {
Line 96: super.syncSearch();
Line 97: Task.Create(this, null).InvokeUIThread();
It can be replaced by calling the 'run' method.
Or, just add 'run' method's content here and remove 'implements ITaskTarget'.
(it's all a legacy of the old client...)
Line 98: }
Line 99:
Line 100: public void UpdateOptionsAsync(String search)
Line 101: {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 139: {
Line 140: privateIsTimerDisabled = value;
Line 141: }
Line 142:
Line 143: // Update IsAsync wisely! Set it once after initializing the
SearchableListModel object.
the isAsync field can be removed as well
Line 144: private boolean privateIsAsync;
Line 145:
Line 146: public boolean getIsAsync()
Line 147: {
Line 773:
Line 774: setIsQueryFirstTime(false);
Line 775: }
Line 776:
Line 777: public void EnsureAsyncSearchStopped()
good idea :)
Line 778: {
Line 779: getTimer().stop();
Line 780: }
Line 781:
--
To view, visit http://gerrit.ovirt.org/14654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica13e40edf51b91cec88405ae275b08c70edef44
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
