Oved Ourfali has posted comments on this change.
Change subject: webadmin: Network Provider main tab
......................................................................
Patch Set 14: Looks good to me, but someone else must approve
(2 inline comments)
Not a UI expert, but overall it looks okay.
Great work :-)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
Line 89: protected void AsyncSearch() {
Line 90: // super.AsyncSearch();
Line 91: //
Line 92: // setAsyncResult(Frontend.RegisterSearch(getSearchString(),
SearchType.Provider, getSearchPageSize()));
Line 93: // setItems(getAsyncResult().getData());
please remove those lines if they aren't relevant.
Line 94: }
Line 95:
Line 96: @Override
Line 97: protected void OnSelectedItemChanged() {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java
Line 34: UICommand lastExecutedCommand, Model windowModel) {
Line 35:
Line 36: // if (lastExecutedCommand ==
getModel().getAddCommand()) {
Line 37: // return editNetworkPopupProvider.get();
Line 38: // } else {
remove comment lines.
Line 39: return super.getModelPopup(source,
lastExecutedCommand, windowModel);
Line 40: // }
Line 41: }
Line 42:
--
To view, visit http://gerrit.ovirt.org/11114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide66dd42695293f66d1a0c6ca4a067fff5e81a1d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
