Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Network Provider main tab
......................................................................
Patch Set 18: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
Line 59: @Override
Line 60: public String getValue(Provider object) {
Line 61: return object.getUrl();
Line 62: }
Line 63: };
what about constants widths and enabling column re-sizing?
Line 64:
Line 65: getTable().addColumn(urlColumn, constants.urlProvider());
Line 66:
Line 67: getTable().addActionButton(new
WebAdminButtonDefinition<Provider>(constants.addProvider()) {
--
To view, visit http://gerrit.ovirt.org/11114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide66dd42695293f66d1a0c6ca4a067fff5e81a1d
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
