Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Network Provider main tab
......................................................................


Patch Set 18: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
Line 20: import org.ovirt.engine.ui.uicompat.ObservableCollection;
Line 21: 
Line 22: public class ProviderListModel extends ListWithDetailsModel implements 
ISupportSystemTreeContext
Line 23: {
Line 24:     private UICommand addCommand;
in all other models the addCommand is called newCommand, for the sake of 
consistency.
Line 25:     private UICommand removeCommand;
Line 26: 
Line 27:     private SystemTreeItemModel systemTreeSelectedItem;
Line 28: 


Line 43:         getSearchNextPageCommand().setIsAvailable(true);
Line 44:         getSearchPreviousPageCommand().setIsAvailable(true);
Line 45:     }
Line 46: 
Line 47:     public void add() {
called newEntity
Line 48:     }
Line 49: 
Line 50:     public void remove() {
Line 51:     }


--
To view, visit http://gerrit.ovirt.org/11114
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide66dd42695293f66d1a0c6ca4a067fff5e81a1d
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to