Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
......................................................................
Patch Set 1: (2 inline comments)
I would separate the work around engine-config to a separate patch.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 84: MigrationSupportForNativeUsb(ConfigAuthType.User),
Line 85: MigrationNetworkEnabled,
Line 86: VncKeyboardLayout(ConfigAuthType.User),
Line 87: VncKeyboardLayoutValidValues(ConfigAuthType.User),
Line 88: SupportCustomDeviceProperties(ConfigAuthType.User),
Why user level? Do we want to see that in User portal? I am not sure... this
should be a question I guess to PM.
Line 89: CustomDeviceProperties(ConfigAuthType.User),
Line 90: ;
Line 91:
Line 92: public static enum ConfigAuthType {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 593:
PERMISSION_REMOVE_FAILED_ONLY_SYSTEM_SUPER_USER_CAN_REMOVE_ADMIN_ROLES,
Line 594: CANNOT_ADD_ACTION_GROUPS_TO_ROLE_TYPE,
Line 595: ROLE_TYPE_CANNOT_BE_EMPTY,
Line 596: ROLE_WITH_ROLE_ID_DO_NOT_EXIST,
Line 597: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_SYNTAX,
What about the app errors files?
Line 598: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_KEYS,
Line 599: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_VALUES,
Line 600: CUSTOM_PROPERTIES_INVALID_VALUES_NOT_ALLOWED_IN_CURRENT_CLUSTER,
Line 601:
--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
