Martin Peřina has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1335:
Line 1336: @TypeConverterAttribute(Boolean.class)
Line 1337: @DefaultValueAttribute("true")
Line 1338: SupportCustomDeviceProperties(505),
Line 1339:
The handling is the same as for UserDefinedVMProperties: CustomDeviceProperties
contains a definition of existing device properties, they can be set through
engine-config and after that engine has to be restarted to reload new custom
device properties definition.
Line 1340: @TypeConverterAttribute(String.class)
Line 1341: @DefaultValueAttribute("")
Line 1342: CustomDeviceProperties(506),
Line 1343:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 84: MigrationSupportForNativeUsb(ConfigAuthType.User),
Line 85: MigrationNetworkEnabled,
Line 86: VncKeyboardLayout(ConfigAuthType.User),
Line 87: VncKeyboardLayoutValidValues(ConfigAuthType.User),
Line 88: SupportCustomDeviceProperties(ConfigAuthType.User),
Well, I thought that by this user can see if custom device properties are
supported ...
Line 89: CustomDeviceProperties(ConfigAuthType.User),
Line 90: ;
Line 91:
Line 92: public static enum ConfigAuthType {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 593:
PERMISSION_REMOVE_FAILED_ONLY_SYSTEM_SUPER_USER_CAN_REMOVE_ADMIN_ROLES,
Line 594: CANNOT_ADD_ACTION_GROUPS_TO_ROLE_TYPE,
Line 595: ROLE_TYPE_CANNOT_BE_EMPTY,
Line 596: ROLE_WITH_ROLE_ID_DO_NOT_EXIST,
Line 597: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_SYNTAX,
Sorry, I don't understand. What do you mean by this?
Line 598: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_KEYS,
Line 599: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_VALUES,
Line 600: CUSTOM_PROPERTIES_INVALID_VALUES_NOT_ALLOWED_IN_CURRENT_CLUSTER,
Line 601:
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
Line 794: return devicePropValidationPattern.matcher(propDef).matches();
Line 795: }
Line 796:
Line 797: /**
Line 798: * Returns string decribing format custom device properties
specification
Sorry, I will fix it
Line 799: */
Line 800: public String getCustomDevicePropSpec() {
Line 801: return devicePropSplitStr;
Line 802: }
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/DeviceCustomPropertiesValueHelper.java
Line 16: boolean result = true;
Line 17: String errMsg = null;
Line 18:
Line 19: // HACK, because ConfigValues are not loaded inside
engine-config
Line 20: Version version = new Version(key.getVersion());
Well, this is the only place where is this version handling used. In all other
cases FeatureSupported.deviceCustomProperties(Version version) should be used.
So is it really needed to create new method for 2 lines of code?
Line 21: if (Version.v3_3.compareTo(version) > 0) {
Line 22: result = false;
Line 23: errMsg = String.format("Device custom properties are not
supported in version %s", version.toString());
Line 24: }
--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
