Martin Peřina has posted comments on this change.

Change subject: core: Adds custom properties to VmDevice
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
Line 666:      *            version of the cluster that the VM containing the 
device is in
Line 667:      * @param device
Line 668:      *            specified device
Line 669:      * @return map containing all device custom properties
Line 670:      */
Sorry, my mistake. This should be used VdsBroker commands to convert string 
based properties of VmDevice to a Map<String,String> used VDSM verbs
Line 671:     public Map<String, String> getDeviceProperties(Version version, 
VmDevice device) {
Line 672:         Map<String, String> map = new HashMap<String, String>();
Line 673:         storeDeviceProperties(version, device, map);
Line 674:         return map;


--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to