Eli Mesika has posted comments on this change. Change subject: engine: add comment field to DataCenter ......................................................................
Patch Set 3: (4 inline comments) .................................................... File backend/manager/dbscripts/storages_sp.sql Line 3: -- Line 4: Line 5: Line 6: Create or replace FUNCTION Insertstorage_pool(v_description VARCHAR(4000), Line 7: v_comment VARCHAR(4000), This should be text Line 8: v_id UUID, Line 9: v_name VARCHAR(40), Line 10: v_storage_pool_type INTEGER, Line 11: v_status INTEGER, Line 25: Line 26: Line 27: Line 28: Create or replace FUNCTION Updatestorage_pool(v_description VARCHAR(4000), Line 29: v_comment VARCHAR(4000), This should be text Line 30: v_id UUID, Line 31: v_name VARCHAR(40), Line 32: v_storage_pool_type INTEGER, Line 33: v_status INTEGER, Line 50: END; $procedure$ Line 51: LANGUAGE plpgsql; Line 52: Line 53: Create or replace FUNCTION Updatestorage_pool_partial(v_description VARCHAR(4000), Line 54: v_comment VARCHAR(4000), This should be text Line 55: v_id UUID, Line 56: v_name VARCHAR(40), Line 57: v_storage_pool_type INTEGER, Line 58: v_storage_pool_format_type VARCHAR(50), .................................................... Commit Message Line 5: CommitDate: 2013-05-20 15:11:23 +0300 Line 6: Line 7: engine: add comment field to DataCenter Line 8: Line 9: As part of the Free Text FRE can you provide the link to this RFE so we can understand how your patch is related to it? Line 10: Line 11: Added to the entities flow in the system Line 12: DB <-> DAO <-> Entity <-> Model <-> UI Line 13: DB <-> DAO <-> Entity <-> REST -- To view, visit http://gerrit.ovirt.org/14878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
