Laszlo Hornyak has posted comments on this change. Change subject: engine: add comment field to DataCenter ......................................................................
Patch Set 3: Allon: Maybe having an empty string is not bad, so that it does not have to be null-checked all the time. As it is comment, an empty string does not seem to be inconsistent. However, in this case I would also place a not null constraint on the field. (clearly paranoia) But accepting the null values could work as well. -- To view, visit http://gerrit.ovirt.org/14878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
