Michal Skrivanek has posted comments on this change.
Change subject: core: [WIP] Use OS repository intead of VmOsType
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 42: XmlNode node = section.SelectSingleNode("Description");
Line 43: if (node != null) {
Line 44: _vm.getStaticData().setOs(Integer.valueOf(node.InnerText));
Line 45: } else {
Line 46: _vm.getStaticData().setOs(0);
any way how to keep this as a constant anywhere?
Line 47: }
Line 48: }
Line 49:
Line 50: @Override
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 62: public static final int VM_TEMPLATE_NAME_MAX_LIMIT = 40;
Line 63: public static final int DESCRIPTION_MAX_LIMIT = 255;
Line 64:
Line 65: // the default os type id
Line 66: public static final String UNASSIGNED = "Unassigned"; //$NON-NLS-1$
this actually should be translated
Line 67:
Line 68: private boolean privateIsNew;
Line 69:
Line 70: public boolean getIsNew()
--
To view, visit http://gerrit.ovirt.org/15078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I168225f20d567910cba861be75be87136926589f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
