Tomas Jelinek has posted comments on this change.
Change subject: core: [WIP] Use OS repository intead of VmOsType
......................................................................
Patch Set 6: (5 inline comments)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java
Line 7: }
Line 8:
Line 9: @Override
Line 10: public String[] getCompletion(String wordPart) {
Line 11: return new String[] {"windows 7, windows 8", "other"};
I guess this is not yet finished...
Line 12: }
Line 13:
Line 14: @Override
Line 15: public boolean validate(String text) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 232: ConfigValues.DesktopAudioDeviceType,
compatibilityVersion.toString());
Line 233: int vmOS = vm.getOs();
Line 234:
Line 235: Pattern regexPattern = Pattern.compile(String
Line 236: .format(OS_REGEX, vmOS));
don't you need to translate it to the name?
Line 237: Matcher regexMatcher =
regexPattern.matcher(soundDeviceTypeConfig);
Line 238:
Line 239: if (regexMatcher.find()) {
Line 240: ret = regexMatcher.group(1);
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
Line 64: @WithElementId("description")
Line 65: Label vmDescription;
Line 66:
Line 67: @UiField
Line 68: @Path("SelectedItem.OsType")
this is bound to UserPortalItemModel.osType which does not exists anymore - I
guess it should be @Path("SelectedItem.OsId")
Line 69: @WithElementId("os")
Line 70: Label operatingSystem;
Line 71:
Line 72: @UiField
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmImageColumn.java
Line 19: }
Line 20:
Line 21: @Override
Line 22: public ImageResource getValue(T item) {
Line 23: String osTypeName =
AsyncDataProvider.getOsName(extractor.extractOsType(item));
not sure this is correct - IIUC this will return strings like "windows 2008 R2
x64" but this class will look for pictures with name ..."windows2008R2x64"
(e.g. without the spaces)
Line 24: ResourcePrototype resource =
getApplicationResourcesWithLookup().getResource(osTypeName + "SmallImage");
//$NON-NLS-1$
Line 25:
Line 26: if (resource == null || !(resource instanceof ImageResource)) {
Line 27: resource =
getApplicationResourcesWithLookup().UnassignedSmallImage();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java
Line 115:
Line 116: // TODO required because of GWT#5864
Line 117:
monitorCount.setText(String.valueOf(getDetailModel().getMonitorCount()));
Line 118:
isStateless.setText(Boolean.toString(getDetailModel().getIsStateless()));
Line 119: oS.setText(String.valueOf(getDetailModel().getOS()));
I guess you should use the name instead of the id of the OS here - this would
show up in the general subtab for the pool as integer id.
Line 120:
Line 121: formBuilder.update(getDetailModel());
Line 122: }
Line 123:
--
To view, visit http://gerrit.ovirt.org/15078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I168225f20d567910cba861be75be87136926589f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
