Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 6: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1339:
Line 1340: @Reloadable
Line 1341: @TypeConverterAttribute(Boolean.class)
Line 1342: @DefaultValueAttribute("false")
Line 1343: ImprovedGetAllTasks(505),
Hope SaferGetAllTasksRequest is better.
Line 1344:
Line 1345: Invalid(65535);
Line 1346:
Line 1347: private int intValue;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetTaskListCommandParameters.java
Line 1: package org.ovirt.engine.core.common.vdscommands;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GetTaskListCommandParameters extends
VdsIdVDSCommandParametersBase {
I don't see reason for that as almost all other commandParameter classes are
called after the name of the command as prefix, this can be the same.
Line 6: public GetTaskListCommandParameters(Guid vdsId) {
Line 7: _vdsId = vdsId;
Line 8: _spUUID = null;
Line 9: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksStatusesVDSCommand.java
Line 36: hostVersions = vds.getSupportedClusterVersionsSet();
Line 37: if
(FeatureSupported.improvedGetAllTasks(clusterCompatibility) &&
Line 38: (hostVersions != null) &&
hostVersions.contains(clusterCompatibility)) {
Line 39: _result =
getBroker().getAllTasksStatuses(getParameters().getStoragePoolId().toString());
Line 40: }
FeatureSupported class helps enough.. if i omit the condition for host
capability and stay only with dc version verification, the scope looks much
cleaner.
Line 41: }
Line 42: if (_result == null) {
Line 43: _result = getBroker().getAllTasksStatuses();
Line 44: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
Line 137: public Map<String, Object> getTaskStatus(String taskUUID);
Line 138:
Line 139: public Map<String, Object> getAllTasksStatuses();
Line 140:
Line 141: public Map<String, Object> getAllTasksStatuses(String spUUID);
Explained as part of the BZ.
Line 142:
Line 143: public Map<String, Object> getAllTasksInfo();
Line 144:
Line 145: public Map<String, Object> getAllTasksInfo(String spUUID);
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
