Liron Ar has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 8: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetTaskListCommandParameters.java
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GetTaskListCommandParameters extends
VdsIdVDSCommandParametersBase {
Line 6: public GetTaskListCommandParameters(Guid vdsId) {
super(vdsId)?
Line 7: spUUID = null;
Line 8: }
Line 9:
Line 10: public GetTaskListCommandParameters(Guid vdsId, Guid spUUID) {
Line 21: public Guid getStoragePoolId() {
Line 22: return spUUID;
Line 23: }
Line 24:
Line 25: public GetTaskListCommandParameters() {
do we really need 3 different constructors for that parameter class?
Line 26: spUUID = null;
Line 27: }
Line 28:
Line 29: @Override
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksInfoVDSCommand.java
Line 19: @Override
Line 20: protected void ExecuteVdsBrokerCommand() {
Line 21: _result = null;
Line 22: if (getParameters().getStoragePoolId() != null) {
Line 23: if
(FeatureSupported.saferGetAllTasksRequest(getVds().getVdsGroupCompatibilityVersion()))
{
why can't we do this by dc level? i don't think that we should have different
behaviour between the host in the same pool - much harder to debug it later IMO
please add a log so that we will be able to know what was called without
checking the vdsm log atleast.
Line 24: _result =
getBroker().getAllTasksInfo(getParameters().getStoragePoolId().toString());
Line 25: }
Line 26: }
Line 27: if (_result == null) {
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
