Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetTaskListCommandParameters.java
Line 11: super(vdsId);
Line 12: setStoragePoolId(spUUID);
Line 13: }
Line 14:
Line 15: private Guid spUUID;
Sorry, should have asked to do that before - I would recommend that to be
storagePoolId (not spUUID) like in many places in engine code.
Line 16:
Line 17: public void setStoragePoolId(Guid value) {
Line 18: spUUID = value;
Line 19: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksInfoVDSCommand.java
Line 23: if
(FeatureSupported.saferGetAllTasksRequest(getVds().getVdsGroupCompatibilityVersion()))
{
Line 24: _result =
getBroker().getAllTasksInfo(getParameters().getStoragePoolId().toString());
Line 25: }
Line 26: }
Line 27: if (_result == null) {
Let's say that the previous call to getAllTasksInfo returns null - do you
really want to perform getBroker().getAllTasksInfo with no args?
Why not use else instead ? something is bothering me here...
Line 28: _result = getBroker().getAllTasksInfo();
Line 29: }
Line 30:
Line 31: ProceedProxyReturnValue();
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
