Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File packaging/services/ovirt-websocket-proxy.sysv.in
Line 36: ulimit -n ${NPROC:-2048}
Line 37: touch "${PIDFILE}"
Line 38: chown "${USER}" "${PIDFILE}"
Line 39: daemon --user "${USER}" --pidfile="${PIDFILE}" \
Line 40:
"${ENGINE_USR}/services/ovirt-websocket-proxy.py" \
should be:
${ENGINE_USR}/services/${NAME}.py
Line 41: --pidfile="${PIDFILE}" \
Line 42: --background \
Line 43: ${EXTRA_ARGS} \
Line 44: start
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
