Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 8: (3 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java
Line 37: File store =
EngineLocalConfig.getInstance().getPKIEngineStore();
Line 38: String password =
EngineLocalConfig.getInstance().getPKIEngineStorePassword();
Line 39: String alias =
EngineLocalConfig.getInstance().getPKIEngineStoreAlias();
Line 40:
Line 41: return new TicketUtils(store, password, alias, 120);
Please don't hard code, take from ConfigValues
Line 42: }
Line 43:
Line 44: public TicketUtils(File store, String password, String alias, int
lifetime) throws
Line 45: KeyStoreException,
....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 48: Called after a new WebSocket connection has been established.
Line 49: """
Line 50: connection_data =
self._ticketDecoder.decode(self.path[1:]).split(':')
Line 51: target_host = connection_data[0].encode('utf8')
Line 52: target_port = connection_data[1].encode('utf8')
strange... python should have dealt with this correctly... jus curious... where
does it fail if you do not do this?
Line 53:
Line 54: # Connect to the target
Line 55: self.msg("connecting to: %s:%s" % (
Line 56: target_host, target_port))
....................................................
File packaging/services/ovirt-websocket-proxy.systemd.in
Line 4: [Service]
Line 5: Type=simple
Line 6: User=@ENGINE_USER@
Line 7: Group=@ENGINE_GROUP@
Line 8: LimitNPROC=2048
Where LimitNOFILE went?
Line 9: ExecStart=@ENGINE_USR@/services/ovirt-websocket-proxy.py $EXTRA_ARGS
start
Line 10:
Line 11: [Install]
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
