Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java
Line 37: File store =
EngineLocalConfig.getInstance().getPKIEngineStore();
Line 38: String password =
EngineLocalConfig.getInstance().getPKIEngineStorePassword();
Line 39: String alias =
EngineLocalConfig.getInstance().getPKIEngineStoreAlias();
Line 40:
Line 41: return new TicketUtils(store, password, alias, 120);
I think it is best to separate these two, as we would like to use the same
component for the spice, right?
Line 42: }
Line 43:
Line 44: public TicketUtils(File store, String password, String alias, int
lifetime) throws
Line 45: KeyStoreException,
....................................................
File packaging/services/ovirt-websocket-proxy.sysv.in
Line 31: echo $"Insufficient privilege" 1>&2
Line 32: exit 4
Line 33: fi
Line 34: echo -n $"Starting $PROG: "
Line 35: ulimit -n ${NPROC:-2048}
Where ulimit -n went?
Line 36: touch "${PIDFILE}"
Line 37: chown "${USER}" "${PIDFILE}"
Line 38: daemon --user "${USER}" --pidfile="${PIDFILE}" \
Line 39:
"${ENGINE_USR}/services/ovirt-websocket-proxy.py" \
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
