Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: Fix behavior unsupported locale
......................................................................
Patch Set 2: (1 inline comment)
- see inline comment
- please verify both locale drop-down content and "...?locale=..." part within
links URLs for the following default browser locales (mark "+1" on the Verified
section once done):
- en-US (page should be "rendered" in en-US)
- != en-US, but supported (e.g. 'ja-JP'; page should be "rendered" in 'ja-JP')
- unsupported (e.g. 'ja', 'ru'; page should fallback to en-US)
Thanks.
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/LocaleFilter.java
Line 78: if (locale == null) { // No accept headers.
Line 79: locale = Locale.US;
Line 80: }
Line 81: log.debug("Filter determined locale to be: " +
locale.toLanguageTag());
Line 82: return lookupSupportedLocale(locale, getLocaleKeys());
I suggest to improve the debug message in this case, and mention in it also the
returned value of "lookupSupportedLocale(locale, getLocaleKeys())", especially
if it is != locale.
Line 83: }
Line 84:
Line 85: /**
Line 86: * Loop over the cookies to determine if the locale is set there.
--
To view, visit http://gerrit.ovirt.org/15520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5beceaf7f4ce2333e83cd72c3fa8721103cf805
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
