Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: Fix behavior unsupported locale
......................................................................
Patch Set 3:
thanks for correcting me, Alex.
it sounds like the behavior that you have described will practically be better
than my simplistic suggestion to always fall-back to English.
however, my concern is that our fallback is from a 'generic' locale (e.g. 'ja')
to a more 'specific' locale (e.g. 'ja-JP'), when generally I think (I could be
wrong) that the expectation is to fallback from a (missing) 'specific' locale
('ja-JP') to a 'generic' locale ('ja') [although this is not applicable in our
case, as all of our supported locales are specific].
thoughts?
--
To view, visit http://gerrit.ovirt.org/15520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5beceaf7f4ce2333e83cd72c3fa8721103cf805
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
