Greg Sheremeta has posted comments on this change.
Change subject: userportal,webadmin: Fix behavior unsupported locale
......................................................................
Patch Set 3: Verified
(1 inline comment)
suggest a tiny improvement to the debug logging. other than that, looks great
to me.
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/LocaleFilter.java
Line 78: if (locale == null) { // No accept headers.
Line 79: locale = Locale.US;
Line 80: }
Line 81: locale = lookupSupportedLocale(locale, getLocaleKeys());
Line 82: log.debug("Filter determined locale to be: " +
locale.toLanguageTag());
suggest changing this so that we can see when a detected locale is (much)
different than the browser/cookie locale
Locale resolvedLocale = lookupSupportedLocale(locale, getLocaleKeys());
log.debug(String.format("Incoming locale: %s. Filter determined locale to be:
%s",
locale.toLanguageTag(), resolvedLocale.toLanguageTag()));
return resolvedLocale;
Line 83: return locale;
Line 84: }
Line 85:
Line 86: /**
--
To view, visit http://gerrit.ovirt.org/15520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5beceaf7f4ce2333e83cd72c3fa8721103cf805
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
