Tal Nisan has posted comments on this change. Change subject: core: add check for iqn in addStorageServerConn ......................................................................
Patch Set 4: (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2013-06-11 17:06:37 +0300 Line 6: Line 7: core: add check for iqn in addStorageServerConn Line 8: Line 9: Add a new validation in canDoACtion that iqn and connection (the adress s/adress/address Line 10: field) properties are not empty in AddStorageServerConnection in case of Line 11: iSCSI storage domains. Also added relevant unitests and error messages. Line 12: Line 13: Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f -- To view, visit http://gerrit.ovirt.org/15516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
