Alissa Bonas has posted comments on this change. Change subject: core: add check for iqn in addStorageServerConn ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 588: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can contain only 'A-Z', 'a-z', '0-9', '_' characters Line 589: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related operations can't be performed while the Storage Pool Manager is down.\nPlease make sure the Storage Pool Manager is up and running, and check network connectivity. Line 590: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please use [IP:/path or FQDN:/path] convention. Line 591: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty. Line 592: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details are empty. OK - any suggestions for a new error? Keep in mind that there is no field in UI named iqn, so the error needs to describe it in a way that corresponds to UI fields. Line 593: VALIDATION.TAGS.INVALID_TAG_NAME=Invalid tag name. Only alphanumeric chars, '-' and '_' characters are valid Line 594: VALIDATION.VM_POOLS.NAME.NOT_NULL=Pool name is required Line 595: VALIDATION.ROLES.NAME.NOT_NULL=Role name is required Line 596: VALIDATION.ROLES.ID.NOT_NULL=Role ID is required .................................................... Commit Message Line 5: CommitDate: 2013-06-11 17:06:37 +0300 Line 6: Line 7: core: add check for iqn in addStorageServerConn Line 8: Line 9: Add a new validation in canDoACtion that iqn and connection (the adress rephrased the entire sentence.... Line 10: field) properties are not empty in AddStorageServerConnection in case of Line 11: iSCSI storage domains. Also added relevant unitests and error messages. Line 12: Line 13: Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f -- To view, visit http://gerrit.ovirt.org/15516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
