Liron Ar has posted comments on this change. Change subject: core: add check for iqn in addStorageServerConn ......................................................................
Patch Set 5: @Alissa - my meaning was that this logic of checking that ISCSI connection has all needed information should be export to a helper method IMO. right now if we will add another mandatory field we will have to add it to 2 places. We can have the validation in a helper class (iscsi storage helper perhaps), check it in each scenario and add the appropriate validation message for that scenario. -- To view, visit http://gerrit.ovirt.org/15516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
