Omer Frenkel has posted comments on this change.
Change subject: core: expand VDS monitoring with cluster emulation modes
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java
Line 94: public void testFirstMatch() {
Line 95: List<String> source = Arrays.asList("zero", "one", "two ",
"three");
Line 96:
Line 97: Assert.assertEquals("one", ListUtils.firstMatch(source, "one",
"two"));
Line 98: Assert.assertEquals("one", ListUtils.firstMatch(source, "two",
"one"));
maybe worth testing no match?
Line 99: }
--
To view, visit http://gerrit.ovirt.org/15868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0caf343d4d883a1e420ca2b4fc24c678436599cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
