Oved Ourfali has posted comments on this change.
Change subject: core: expand VDS monitoring with cluster emulation modes
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/GlusterMonitoringStrategy.java
Line 20:
Line 21: @Override
Line 22: public boolean hostCompliesWithClusterEmulationMode(VDS vds,
VDSGroup vdsGroup) {
Line 23: return true; // non issue here as emulation mode is related to
VM migration
Line 24: }
s/non/no
Line 25:
Line 26: @Override
Line 27: public void processSoftwareCapabilities(VDS vds) {
Line 28: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategy.java
Line 34:
Line 35: /**
Line 36: * Process cluster wide compatibility with this host emulated
machine flags.
Line 37: */
Line 38: public boolean hostCompliesWithClusterEmulationMode(VDS vds,
VDSGroup vdsGroup);
I think you can use the processSoftwareCapabilities.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
Line 68:
Line 69: @Override
Line 70: public void processSoftwareCapabilities(VDS vds) {
Line 71: boolean softwareCapabilitiesAreMet = true;
Line 72:
if using processSoftwareCapabilities, then you can call the methods above (or a
new method) from within this one.
Line 73: // If we can't test for those capabilities, we don't say they
don't exist
Line 74: if (vds.getKvmEnabled() != null &&
vds.getKvmEnabled().equals(false)) {
Line 75: softwareCapabilitiesAreMet = false;
Line 76: }
Line 86:
ResourceManager.getInstance().getEventListener().processOnCpuFlagsChange(vds.getId());
Line 87: }
Line 88:
Line 89: protected void vdsNonOperational(VDS vds) {
Line 90:
ResourceManager.getInstance().getEventListener().vdsNonOperational(vds.getId(),
NonOperationalReason.KVM_NOT_RUNNING, true, true, Guid.Empty);
It would help if you change this method signature, to get the non operation
reason, and perhaps other things you might need.
Line 91: }
Line 92:
Line 93: @Override
Line 94: public boolean processHardwareCapabilitiesNeeded(VDS oldVds, VDS
newVds) {
--
To view, visit http://gerrit.ovirt.org/15909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I033560bcee25ca4fac7d96606ae4cfbe7013ee09
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
