Oved Ourfali has posted comments on this change.
Change subject: core: expand VDS monitoring with cluster emulation modes
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
Line 40: vdsNonOperational(vds,
NonOperationalReason.KVM_NOT_RUNNING, null);
Line 41: vds.setStatus(VDSStatus.NonOperational);
Line 42: }
Line 43:
Line 44: VDSGroup vdsGroup =
DbFacade.getInstance().getVdsGroupDao().get(vds.getVdsGroupId());
Shouldn't this all be in an "else" statement?
Do we support moving a host to non-operational twice, showing two reasons?
Line 45: if (!hostCompliesWithClusterEmulationMode(vds, vdsGroup) &&
vds.getStatus() != VDSStatus.NonOperational) {
Line 46:
Line 47: Map<String, String> customLogValues = new HashMap<>();
Line 48: customLogValues.put("hostSupportedEmulatedMachines",
vds.getSupportedEmulatedMachines());
Line 61:
ResourceManager.getInstance().getEventListener().processOnCpuFlagsChange(vds.getId());
Line 62: }
Line 63:
Line 64: protected void vdsNonOperational(VDS vds, NonOperationalReason
reason, Map<String, String> customLogValues) {
Line 65:
ResourceManager.getInstance().getEventListener().vdsNonOperational(vds.getId(),
reason, true, true, Guid.Empty, customLogValues);
just to be sure, does it cope well with null customLogValues?
Line 66: }
Line 67:
Line 68: @Override
Line 69: public boolean processHardwareCapabilitiesNeeded(VDS oldVds, VDS
newVds) {
--
To view, visit http://gerrit.ovirt.org/15909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I033560bcee25ca4fac7d96606ae4cfbe7013ee09
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
