Oved Ourfali has posted comments on this change.
Change subject: core: expand VDS monitoring with cluster emulation modes
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
If you think my review is enough then consider this a +2.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
Line 40: vdsNonOperational(vds,
NonOperationalReason.KVM_NOT_RUNNING, null);
Line 41: vds.setStatus(VDSStatus.NonOperational);
Line 42: }
Line 43:
Line 44: VDSGroup vdsGroup =
DbFacade.getInstance().getVdsGroupDao().get(vds.getVdsGroupId());
I see. missed that before.
In any way, i think it is better to just put it in the else, consider changing
it, although but I'm fine with the current patch-set as well.
Line 45: if (!hostCompliesWithClusterEmulationMode(vds, vdsGroup) &&
vds.getStatus() != VDSStatus.NonOperational) {
Line 46:
Line 47: Map<String, String> customLogValues = new HashMap<>();
Line 48: customLogValues.put("hostSupportedEmulatedMachines",
vds.getSupportedEmulatedMachines());
--
To view, visit http://gerrit.ovirt.org/15909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I033560bcee25ca4fac7d96606ae4cfbe7013ee09
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
