Alon Bar-Lev has posted comments on this change.
Change subject: packaging: added DB validation functions
......................................................................
Patch Set 9: (4 inline comments)
thanks!!! minor formatting comments left.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
Line 161:
Line 162: return (
Line 163: [
Line 164: _(
Line 165: '---- Task ID: {task_id:30} -------\n'
equal number of dashes at both sides? :)
Better add header as capital TASK ID XXXX (without alignment), and consider
removing the dashes.
Line 166: 'Task Name: {task_name:30}\n'
Line 167: 'Task Description: {task_desc:30}\n'
Line 168: 'Started at: {started_at:30}\n'
Line 169: 'DC Name: {name:30}'
Line 287: True
Line 288: )
Line 289: self.environment.setdefault(
Line 290: osetupcons.AsyncTasksEnv.CLEAR_TASKS_WAIT_PERIOD,
Line 291: osetupcons.Defaults.DEFAULT_CLEAR_TASKS_WAIT_PERIOD,
remove comma?
Line 292: )
Line 293:
Line 294: @plugin.event(
Line 295: stage=plugin.Stages.STAGE_VALIDATION,
Line 294: @plugin.event(
Line 295: stage=plugin.Stages.STAGE_VALIDATION,
Line 296: condition=lambda self: self.environment[
Line 297: osetupcons.AsyncTasksEnv.CLEAR_TASKS
Line 298: ]
comma
Line 299: )
Line 300: def _validateZombies(self):
Line 301: self.logger.info(
Line 302: _('Cleaning stale zombie tasks')
Line 307: stage=plugin.Stages.STAGE_VALIDATION,
Line 308: priority=plugin.Stages.PRIORITY_LOW,
Line 309: condition=lambda self: self.environment[
Line 310: osetupcons.AsyncTasksEnv.CLEAR_TASKS
Line 311: ]
comma
Line 312: )
Line 313: def _validateAsyncTasks(self):
Line 314: self.logger.info(
Line 315: _('Cleaning async tasks and compensations')
--
To view, visit http://gerrit.ovirt.org/15970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
