Alex Lourie has posted comments on this change.
Change subject: packaging: added DB validation functions
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
Line 134: '-q',
Line 135: ),
Line 136: raiseOnError=False,
Line 137: envAppend={
Line 138: 'PGPASSFILE': self.environment[
but if we don't do PGPASSFILE, how will environment get this value? This is
required by an external application that is standalone and requires PGPASSFILE
env. variable to be defined so that it works correctly.
Line 139: osetupcons.DBEnv.PGPASS_FILE
Line 140: ]
Line 141: },
Line 142: )
....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/dbvalidations.py
Line 106: )
Line 107: def _setup(self):
Line 108: self._enabled = os.path.exists(
Line 109: osetupcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_CERT
Line 110: )
yes, that is exactly what we do for checking upgrade. It's the same as in the
check for legacy upgrade. Should we create a new function for it, say in misc
plugin?
Line 111:
Line 112: @plugin.event(
Line 113: stage=plugin.Stages.STAGE_VALIDATION,
Line 114: priority=plugin.Stages.PRIORITY_LOW,
--
To view, visit http://gerrit.ovirt.org/15970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
