Alon Bar-Lev has posted comments on this change. Change subject: packaging: added DB validation functions ......................................................................
Patch Set 12: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py Line 310: self._enabled and Line 311: self.environment[ Line 312: osetupcons.AsyncTasksEnv.CLEAR_TASKS, Line 313: ] Line 314: ), please move this condition within the phase and set _enabled to false so that you do not need to specify it again. Line 315: after=[ Line 316: osetupcons.Stages.DB_CREDENTIALS_AVAILABLE, Line 317: ], Line 318: ) -- To view, visit http://gerrit.ovirt.org/15970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
