Tomas Jelinek has posted comments on this change.
Change subject: frontend: change VM status icons
......................................................................
Patch Set 7: (5 inline comments)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java
Line 15: if (vm == null) {
Line 16: return getApplicationResources().vmStatusRunning();
Line 17: }
Line 18:
Line 19: if (vm.isRunOnce()) {
well, I'm not a real fan of ternary operator. If you don't mind I would stay
with it-else
Line 20: return getApplicationResources().runOnceUpImage();
Line 21: } else {
Line 22: return getApplicationResources().vmStatusRunning();
Line 23: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
Line 36: String tooltip;
Line 37:
Line 38: switch (status) {
Line 39: case Up:
Line 40: if (vm.isRunOnce()) {
well, I'm not a real fan of ternary operator. If you don't mind I would stay
with it-else
Line 41: tooltip = constants.runOnce();
Line 42: statusImage = resources.runOnceUpImage();
Line 43: } else {
Line 44: tooltip = constants.up();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java
Line 34:
Line 35: @Override
Line 36: public ImageResource getValue(VM vm) {
Line 37: if (vm.getVmPoolId() == null) {
Line 38: VmTypeConfig config = new VmTypeConfig(vm.isStateless(),
vm.getVmType());
Done
Line 39:
Line 40: if (configToIcon.containsKey(config)) {
Line 41: Pair<ImageResource, String> value =
configToIcon.get(config);
Line 42: setTitle(value.getSecond());
Line 41: Pair<ImageResource, String> value =
configToIcon.get(config);
Line 42: setTitle(value.getSecond());
Line 43: return value.getFirst();
Line 44: } else {
Line 45: return getApplicationResources().manyDesktopsImage();
Done
Line 46: }
Line 47: } else {
Line 48: return getApplicationResources().manyDesktopsImage();
Line 49: }
Line 48: return getApplicationResources().manyDesktopsImage();
Line 49: }
Line 50: }
Line 51:
Line 52: class VmTypeConfig {
Done
Line 53:
Line 54: private boolean stateless;
Line 55:
Line 56: private VmType vmType;
--
To view, visit http://gerrit.ovirt.org/16374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b16f63527158d4cd44b0b39aed5010d61c2115
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
