Vojtech Szocs has posted comments on this change.
Change subject: frontend: change VM status icons
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java
Line 15: if (vm == null) {
Line 16: return getApplicationResources().vmStatusRunning();
Line 17: }
Line 18:
Line 19: if (vm.isRunOnce()) {
OK, if-else is fine for me, too.
Line 20: return getApplicationResources().runOnceUpImage();
Line 21: } else {
Line 22: return getApplicationResources().vmStatusRunning();
Line 23: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
Line 36: String tooltip;
Line 37:
Line 38: switch (status) {
Line 39: case Up:
Line 40: if (vm.isRunOnce()) {
OK, if-else is fine for me, too.
Line 41: tooltip = constants.runOnce();
Line 42: statusImage = resources.runOnceUpImage();
Line 43: } else {
Line 44: tooltip = constants.up();
--
To view, visit http://gerrit.ovirt.org/16374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b16f63527158d4cd44b0b39aed5010d61c2115
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
