Vojtech Szocs has posted comments on this change.
Change subject: frontend: change VM status icons
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java
Line 21: setTitle(config.getTooltip(constants));
Line 22: return
config.getImageResource(getApplicationResources());
Line 23: } else {
Line 24: return getApplicationResources().manyDesktopsImage();
Line 25: }
+1
Nice code, enum is really handy here :-)
Line 26: }
Line 27:
Line 28: }
Line 29:
Line 89: },
Line 90: ;
Line 91:
Line 92: VmType vmType;
Line 93: boolean stateless;
I'd rather avoid potential mutability of these fields using private & final.
Line 94:
Line 95: VmTypeConfig() {
Line 96:
Line 97: }
Line 92: VmType vmType;
Line 93: boolean stateless;
Line 94:
Line 95: VmTypeConfig() {
Line 96:
You could call:
this(null, false);
Line 97: }
Line 98:
Line 99: VmTypeConfig(VmType vmType, boolean stateless) {
Line 100: this.vmType = vmType;
--
To view, visit http://gerrit.ovirt.org/16374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b16f63527158d4cd44b0b39aed5010d61c2115
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
