Sergey Gotliv has posted comments on this change.
Change subject: engine: Validate NfsTimeo and NfsRetarns
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 632: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please
use [IP:/path or FQDN:/path] convention.
Line 633: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty.
Line 634: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details cannot be
empty.
Line 635: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field
cannot be empty.
Line 636: VALIDATION_STORAGE_CONNECTION_NFS_RETRUNS=NFS Retarns should be
between 0 and 32767
The same remark like in other AppErrors.properties
Line 637: VALIDATION_STORAGE_CONNECTION_NFS_TIMEO=NFS Timeo should be between 1
and 6000
Line 638: VALIDATION.TAGS.INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 639: VALIDATION.VM_POOLS.NAME.NOT_NULL=Pool name is required
Line 640: VALIDATION.VM_POOLS.NUMBER_OF_MAX_ASSIGNED_VMS_OUT_OF_RANGE=Number of
max assigned VMs per user must be at least 1.
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 2272: @DefaultStringValue("Mount path is illegal, please use [IP:/path
or FQDN:/path] convention.")
Line 2273: String VALIDATION_STORAGE_CONNECTION_INVALID();
Line 2274:
Line 2275: @DefaultStringValue("NFS Retarns should be between 0 and 32767")
Line 2276: String VALIDATION_STORAGE_CONNECTION_NFS_RETRUNS();
Retarns -> Retrans
Line 2277:
Line 2278: @DefaultStringValue("NFS Timeo should be between 1 and 6000")
Line 2279: String VALIDATION_STORAGE_CONNECTION_NFS_TIMEO();
Line 2280:
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 621: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please
use [IP:/path or FQDN:/path] convention.
Line 622: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty.
Line 623: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details cannot be
empty.
Line 624: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field
cannot be empty.
Line 625: VALIDATION_STORAGE_CONNECTION_NFS_RETRUNS=NFS Retarns should be
between 0 and 32767
s/RETRUNS/RETRANS
s/Retarns/Retrans
Line 626: VALIDATION_STORAGE_CONNECTION_NFS_TIMEO=NFS Timeo should be between 1
and 6000
Line 627: VALIDATION_TAGS_INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 628: VALIDATION_VM_POOLS_NAME_NOT_NULL=Pool name is required
Line 629: VALIDATION_ROLES_NAME_NOT_NULL=Role name is required
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 638: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please
use [IP:/path or FQDN:/path] convention.
Line 639: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty.
Line 640: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details cannot be
empty.
Line 641: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field
cannot be empty.
Line 642: VALIDATION_STORAGE_CONNECTION_NFS_RETRUNS=NFS Retarns should be
between 0 and 32767
s/Retarns/Retrans
s/RETRUNS/RETRANS
Line 643: VALIDATION_STORAGE_CONNECTION_NFS_TIMEO=NFS Timeo should be between 1
and 6000
Line 644: VALIDATION_TAGS_INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 645: VALIDATION_VM_POOLS_NAME_NOT_NULL=Pool name is required
Line 646: VALIDATION_ROLES_NAME_NOT_NULL=Role name is required
--
To view, visit http://gerrit.ovirt.org/17182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d35b2547bb36d17e29c90a05854fe6f897d5d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
