Allon Mureinik has posted comments on this change.
Change subject: engine: Validate NfsTimeo and NfsRetarns
......................................................................
Patch Set 3: (3 inline comments)
Agree with all the comments, will fix.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
Line 159: public void setNfsVersion(NfsVersion nfsVersion) {
Line 160: this.nfsVersion = nfsVersion;
Line 161: }
Line 162:
Line 163: @Min(value = 0, message =
"VALIDATION_STORAGE_CONNECTION_NFS_TIMEO")
The correct min is 1 (see
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java:205).
Fixed.
Line 164: @Max(value = 6000, message =
"VALIDATION_STORAGE_CONNECTION_NFS_TIMEO")
Line 165: private Short nfsTimeo;
Line 166:
Line 167: public Short getNfsTimeo() {
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 633: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty.
Line 634: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details cannot be
empty.
Line 635: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field
cannot be empty.
Line 636: VALIDATION_STORAGE_CONNECTION_NFS_RETRUNS=NFS Retarns should be
between 0 and 32767
Line 637: VALIDATION_STORAGE_CONNECTION_NFS_TIMEO=NFS Timeo should be between 1
and 6000
Good point.
I doublechecked the UI, and those terms are used - will fix.
Line 638: VALIDATION.TAGS.INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 639: VALIDATION.VM_POOLS.NAME.NOT_NULL=Pool name is required
Line 640: VALIDATION.VM_POOLS.NUMBER_OF_MAX_ASSIGNED_VMS_OUT_OF_RANGE=Number of
max assigned VMs per user must be at least 1.
Line 641: VALIDATION.ROLES.NAME.NOT_NULL=Role name is required
....................................................
Commit Message
Line 3: AuthorDate: 2013-07-21 19:20:57 +0300
Line 4: Commit: Allon Mureinik <[email protected]>
Line 5: CommitDate: 2013-07-22 19:25:04 +0300
Line 6:
Line 7: engine: Validate NfsTimeo and NfsRetarns
Done
Line 8:
Line 9: Added @Max and @Min validations on nfsTimeo and nfsRetrans in order to
Line 10: offer a better value validation instead of just failing the command in
Line 11: VDSM side if a negative value is given.
--
To view, visit http://gerrit.ovirt.org/17182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d35b2547bb36d17e29c90a05854fe6f897d5d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
