Sandro Bonazzola has posted comments on this change.

Change subject: ovirt-live: migrate ovirt live plugin to otopi
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File fedora/oVirtLiveFiles/OLPlugin/__init__.py
Line 23: 
Line 24: from otopi import util
Line 25: 
Line 26: 
Line 27: from . import core
the following modules don't exist
Line 28: from . import cpu
Line 29: from . import sshd
Line 30: from . import super_user
Line 31: from . import vdsm


Line 29: from . import sshd
Line 30: from . import super_user
Line 31: from . import vdsm
Line 32: from . import storage
Line 33: from . import firewall
missing ovirt_live module
Line 34: 
Line 35: 
Line 36: @util.export
Line 37: def createPlugins(context):


Line 34: 
Line 35: 
Line 36: @util.export
Line 37: def createPlugins(context):
Line 38:     core.Plugin(context=context)
same here:
Line 39:     cpu.Plugin(context=context)
Line 40:     sshd.Plugin(context=context)
Line 41:     super_user.Plugin(context=context)
Line 42:     vdsm.Plugin(context=context)


-- 
To view, visit http://gerrit.ovirt.org/17518
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to